Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a directory option to download data in ECCORestoring #306

Merged
merged 28 commits into from
Dec 23, 2024

Conversation

simone-silvestri
Copy link
Collaborator

@simone-silvestri simone-silvestri commented Dec 19, 2024

we could also call it just dir instead of data_dir since that's how we call it in ECCOMetadata and JRA55_field_time_series

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (cc8a883) to head (8052736).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/DataWrangling/ECCO/ECCO_restoring.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #306   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         34      34           
  Lines       1982    1982           
=====================================
  Misses      1982    1982           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simone-silvestri simone-silvestri changed the title Add an option to download data in a specific directory in ECCORestoring Add a directory option to download data in ECCORestoring and JRA55PrescribedAtmosphere Dec 19, 2024
@simone-silvestri simone-silvestri changed the title Add a directory option to download data in ECCORestoring and JRA55PrescribedAtmosphere Add a directory option to download data in ECCORestoring Dec 19, 2024
@glwagner
Copy link
Member

dir is better for sure. I'm not sure how I would interpret the difference between dir and data_dir?

Copy link
Collaborator

@navidcy navidcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simone-silvestri simone-silvestri merged commit 4487544 into main Dec 23, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants